ports/51121: MAINTAINER-UPDATE: net/trafshow fix ncurses dependency

Ryan Thompson ryan at sasknow.com
Fri Apr 18 06:20:03 UTC 2003


>Number:         51121
>Category:       ports
>Synopsis:       MAINTAINER-UPDATE: net/trafshow fix ncurses dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 17 23:20:01 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Ryan Thompson
>Release:        FreeBSD 4.7-RELEASE-p6 i386
>Organization:
SaskNow Technologies
>Environment:
System: FreeBSD ren.sasknow.com 4.7-RELEASE-p6 FreeBSD 4.7-RELEASE-p6 #0: Thu Feb 27 12:55:10 CST 2003 hutenosa at ren.sasknow.com:/customer/renhome/obj/usr/src/sys/REN i386

>Description:

Submitted by Peter Pentchev <roam at ringlet.net>:

    During the configure stage, trafshow looks for a suitable ncurses
    library it can use.  The search is unconditionally performed in the
    order of -lslang, -lncurses, -I/usr/include/ncurses, -lcurses.
    Thus, if the devel/libslang port is installed, trafshow will detect
    and use the slang libraries, creating an undocumented library
    dependency.

    What do you think about the attached patch, which uses a method
    similar to that of the news/tin port to conditionally add
    devel/libslang as a lib dependency?
    
Also bump PORTREVISION, and be picky about the grammar in COMMENT.

>How-To-Repeat:
>Fix:

diff -ruN trafshow.orig/Makefile trafshow/Makefile
--- trafshow.orig/Makefile	Sat Feb 22 03:37:56 2003
+++ trafshow/Makefile	Thu Apr 17 21:40:00 2003
@@ -7,18 +7,23 @@
 
 PORTNAME=	trafshow
 PORTVERSION=	3.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	net
 MASTER_SITES=	ftp://ftp.sasknow.com/pub/trafshow/ \
 		ftp://ftp.nsk.su/pub/RinetSoftware/
 EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	ryan at sasknow.com
-COMMENT=	Full screen visualization of the network traffic
+COMMENT=	Full screen visualization of network traffic
 
 .include <bsd.port.pre.mk>
+.if defined(WITH_TRAFSHOW_SLANG) || \
+    (exists(${LOCALBASE}/lib/libslang.a) && !defined(WITHOUT_TRAFSHOW_SLANG))
+LIB_DEPENDS=   slang.1:${PORTSDIR}/devel/libslang
+.else
 .if ${OSVERSION} < 400010
 LIB_DEPENDS=	ncurses.5:${PORTSDIR}/devel/ncurses
+.endif
 .endif
 
 USE_REINPLACE=	yes

>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list