ports/50898: abcde netbsd patch merge and cddb proto addition

[Munish Chopra]

The following reply was made to PR ports/50898; it has been noted by GNATS.

From: Munish Chopra <mchopra at engmail.uwaterloo.ca>
To: "Bjoern A. Zeeb" <bzeeb+freebsdports at zabbadoz.net>
Cc: FreeBSD-gnats-submit at freebsd.org
Subject: Re: ports/50898: abcde netbsd patch merge and cddb proto addition
Date: Tue, 15 Apr 2003 09:43:51 -0400

 On 2003-04-13 13:00 +0000, Bjoern A. Zeeb wrote:
 
 > >Description:
 > 	NetBSD has some more abcde patches that p.ex. include audio/normalize
 > 	support.
 > 
 > 	cddb-tool has hard coded proto=3 which is no good as p.ex. with
 > 	proto=5 one also gets DGENRE and DYEAR which may be usefull
 > 	for tagging audio files.
 > 
 > 
 > >Fix:
 > 
 > 	I placed a diff (which is more or less a "quick-diff" as I didn't
 > 	verify everything) on
 > 
 > 	http://sources.zabbadoz.net/freebsd/ports/abcde-20030412-01.diff
 >
 
 I have very little time at the moment to actually test the diff. By your
 description and a (very) quick perusal it looks fine, I hope to be able
 to test it within the next few days. Unfortunately I wouldn't have time
 to actually do much ripping and see how it holds up - if you have time
 to do that yourself it would be a great help.
  
 > 	- patch-b? should be more or less netbsd patches merged and partly
 > 	  modified.
 > 	  One may check if normalizing is on by default even if dependency
 > 	  not selected. I didn't do this.
 > 	- patch-d? should be my patches for dynamic cddb proto version (5..3)
 > 	  detection.
 > 	  There already had been code in abcde parsing proto 4 return
 > 	  codes from cddb server (proto 4: cddb query -> 210).
 > 	  This patch will break cddb-tool usage if not called from abcde as I
 > 	  needed to change parameters for dynamic proto version adaption
 > 	  from outside.
 > 	  It also adds YEAR and GENRE tagging to vorbiscomment. Perhaps one
 > 	  also wants to add this for other tagging programs.
 > 
 > 	- docu update for patch-d? is missing. Did not read what netbsd did
 > 	  update in their patches.
 > 
 > 	Please review before blindly applying ;-)
 > 	If you consinder them usefull perhaps send them upstream to abcde
 > 	author coordination with netbsd people.
 > 
 > 	Thanks.
 
 The author has handed the project over to someone else, I hope to hear
 more from them soon. Once these patches have been added, I will push to
 get them into the vendor code.
 
 Thanks for taking the time to do this, there is some pretty cool (and
 needed) functionality in these diffs.
 
 -- 
 Munish Chopra