[Bug 226850] [pf] Matching but failed rules block without return

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226850

--- Comment #15 from Kristof Provost <kp at freebsd.org> ---
(In reply to vegeta from comment #14)
Thanks for the patch. I think it looks good, but I've got one question.

I see that you removed the (r->rule_flag & PFRULE_RETURNRST) || (r->rule_flag &
PFRULE_RETURN)) condition from the IPPROTO_TCP case. I think that might result
in a subtle behaviour change for rules which have PFRULE_RETURNICMP set (but
not one of the other returns). (I.e. it'd return a TCP RST, where it didn't use
to do so.

Am I missing something, or should those checks be kept?

-- 
You are receiving this mail because:
You are the assignee for the bug.