[Bug 230619] pf: tables use non SMP-friendly counters

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230619

Andrey V. Elsukov <ae at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ae at FreeBSD.org

--- Comment #1 from Andrey V. Elsukov <ae at FreeBSD.org> ---
It seems you don't check the result of counter allocation, that with M_NOWAIT
can fail. And then you are doing an access to such pointers. I'm not familiar
with PF, but what happens if you try to limit UMA zone used for these counters
and try to create enough number of entries? I suspect it will just panic. Also,
PCPU counters are very expensive memory consumers, on modern machines with tens
CPU cores, they require a lot of memory. And tables usually used to keep large
number of entries, at least for ipfw. Is it really needed feature for PF for
such cost?

-- 
You are receiving this mail because:
You are the assignee for the bug.