pf tables locking

[Kristof Provost]

On 14 Aug 2018, at 0:32, Kajetan Staszkiewicz wrote:
> On Monday, 13 August 2018 17:59:15 CEST Kristof Provost wrote:
> How about this?
>
> https://github.com/innogames/freebsd/commit/
> d44a0d9487285fac8ed1d7372cc99cca83f616e6
>
That looks good to me.
There’s a few minor issues, things like inconsistent indentation and 
overly long lines, but that’s about the only criticism I have.

>> Do you have a bit more information about your use case? What are you 
>> trying
>> to accomplish with this change?
>
> I have a loadbalancer which uses pf and route-to targets. After a 
> server is
> added to a pool, I want this server to immediately take over much 
> traffic.
> With round-robin the server receives new clients rather slowly. If 
> kernel
> could measure amount of states per table entry, I could send new 
> clients to
> this new server until it serves as many clients as other servers.
>
I see. I’m not quite sure yet if that’s a feature we want to import 
or not,
but at least your ‘support’ patches should probably go in. The above 
one certainly.

>>> There are some more issues I found around pf_map_addr. Some of them 
>>> I
>>> mentioned in 
>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229092.
>>> Some
>>> more came out while working on this least-states loadbalancing. I 
>>> will
>>> group them into something meaningful and make another PR for them.
>>
>> Yeah, that bug is still on my todo list somewhere, but things are 
>> extremely
>> hectic at the moment, and I can’t make any promises about when 
>> I’ll have
>> time for it.
>
> I thought that was rather on my todo :)
>
I’m not going to stop you. I love it when other people do the work ;)

Regards,
Kristof