[Differential] D1944: PF and VIMAGE fixes
kristof (Kristof Provost)
phabric-noreply at FreeBSD.org
Sun Apr 24 11:33:21 UTC 2016
kristof added inline comments.
INLINE COMMENTS
sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is always going to be curvnet?
sys/netpfil/pf/pf_if.c:141 Why add curvnet here?
pfi_attach_ifnet_event doesn't use its argument.
sys/netpfil/pf/pf_if.c:143 Same as above.
sys/netpfil/pf/pf_if.c:151 Same as above.
sys/netpfil/pf/pf_if.c:814 I believe this is correct, but should probably include adding an __unused annotation to arg, and removing the 'curvnet' argument from the EVENTHANDLER_REGISTER() call.
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list
More information about the freebsd-pf
mailing list