[Bug 198868] pf brakes tcp checksum if enabled for ue adapter

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Oct 14 16:22:17 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198868

--- Comment #3 from commit-hook at freebsd.org ---
A commit references this bug:

Author: kp
Date: Wed Oct 14 16:21:42 UTC 2015
New revision: 289316
URL: https://svnweb.freebsd.org/changeset/base/289316

Log:
  pf: Fix TSO issues

  In certain configurations (mostly but not exclusively as a VM on Xen) pf
  produced packets with an invalid TCP checksum.

  The problem was that pf could only handle packets with a full checksum. The
  FreeBSD IP stack produces TCP packets with a pseudo-header checksum (only
  addresses, length and protocol).
  Certain network interfaces expect to see the pseudo-header checksum, so they
  end up producing packets with invalid checksums.

  To fix this stop calculating the full checksum and teach pf to only update
TCP
  checksums if TSO is disabled or the change affects the pseudo-header
checksum.

  PR:        154428, 193579, 198868
  Reviewed by:    sbruno
  MFC after:    1 week
  Relnotes:    yes
  Sponsored by:    RootBSD
  Differential Revision:    https://reviews.freebsd.org/D3779

Changes:
  head/sys/net/pfvar.h
  head/sys/netpfil/pf/pf.c
  head/sys/netpfil/pf/pf_ioctl.c
  head/sys/netpfil/pf/pf_norm.c

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-pf mailing list