svn commit: r240646 - head/sys/contrib/altq/altq

[Gleb Smirnoff]

  Ermal,

On Tue, Sep 18, 2012 at 06:02:06PM +0200, Ermal Lu?i wrote:
E> The issue is that this hides the problem per se.

What had hidden problem per se, was the following code:

                        PF_UNLOCK();
                        error = altq_add(a2);
                        PF_LOCK();

That's what we have in stable/9.

E> The ioctl and pfctl loading of ruleset is not ready for handling failures here!

They do. Error from altq_add() is returned by pf_ioctl() as response
to DIOCADDALTQ command. The code in pfctl, which does DIOCADDALTQ also
is handling errors.

-- 
Totus tuus, Glebius.