kern/163208: [pf] PF state key linking mismatch

[Ermal Luçi]

On Sun, Jan 22, 2012 at 11:41 AM, Tilman Keskinöz <arved at freebsd.org> wrote:

> * Bjoern A. Zeeb [Sat, 21 Jan 2012 21:01:41 +0000]:
> >
> > On 21. Jan 2012, at 20:52 , Tilman Keskinöz wrote:
> >
> >>
> >> On Jan 21, 2012, at 21:01 , Fabian Keil wrote:
> >>
> >>> Tilman Keskinöz <arved at FreeBSD.org> wrote:
> >>>
> >>>> Same here.
> >>>>
> >>>> Also Fabian Keil reported this in
> >>>>
> http://lists.freebsd.org/pipermail/freebsd-current/2011-July/025696.html
> >>>
> >>> This has been fixed in CURRENT shortly thereafter:
> >>> http://lists.freebsd.org/pipermail/freebsd-pf/2011-July/006199.html
> >>>
> >>> Maybe the fix hasn't been MFC'd.
> >>
> >> Hm, r223765 happend before the RELENG_9 Branchpoint.
> >> So maybe the Fix was not complete?
> >
> > See thread from earlier this month on freebsd-pf
> >
>
> The Thread suggests:
>
> * Matt Lager [Thu, 12 Jan 2012 15:48:23 -0700]:
> > So it looks likeI can comment out this code in
> > /usr/src/sys/contrib/pf/net/pf.c:
> >
> >                 /* mismatch. must not happen. */
> >                 printf("pf: state key linking mismatch! dir=%s, "
> >                     "if=%s, stored af=%u, a0: ",
> >                     dir == PF_OUT ? "OUT" : "IN", kif->pfik_name, a->af);
> >
> > When this error occurs, I guess for valid reasons, does PF drop packets
> > or do something else with them, or is this purely an information  notice?
>
> I can confirm that removing this printf, brings back the performance for
> me.
>
>

Probably a sysctl to disable this should be provided.
There might be unexpected consequences from this and the better fix is to
find the section where the mbuf is being reused.


> Please fix :)
>
>  _______________________________________________
> freebsd-pf at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-pf
> To unsubscribe, send any mail to "freebsd-pf-unsubscribe at freebsd.org"
>



-- 
Ermal