[pf4freebsd] Re: if_fxp.c.patch

[Max Laier]

On Tuesday 22 June 2004 21:42, Dennis Berger wrote:
> Max Laier wrote:
> >On Tuesday 22 June 2004 10:59, Dennis Berger wrote:
> ><...>
> >
> >>>Spoken too quick ... I am able to reprocure and have a dump now, thanks
> >>>for the head up ... I'll inform you when I have a conclusion. Thanks.
> >
> >Okay ... good news - should be fixed now/was not lock related at all. Bad
> > news - it was plain stupidity. I forgot to check whether IFQ_DRV_DEQUEUE
> > was
>
> so a check around IFQ_DRV_DEQUEUE was needed, why is this check needed
> by the way?
> does IF_DEQUEUE check this normally?

No ... IF_DEQUEUE would just "always" succeed. IFQ_DEQUEUE can fail even if 
not IFQ_IS_EMPTY (under rate limiting e.g.). Most drivers already do this 
check (as w/ kernel threads one could remove a packet from the queue even w/ 
the old macros) - so maybe this can be considered a bug in if_fxp.c (which 
will be fixed with the altq transformation.)

> >really able to give us an mbuf.
> >
> >Please check out the new diff and test again. Thanks and sorry.
>
> I'll do that

Thanks

-- 
Best regards,				| mlaier at freebsd.org
Max Laier				| ICQ #67774661
http://pf4freebsd.love2party.net/	| mlaier at EFnet
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: signature
Url : http://lists.freebsd.org/pipermail/freebsd-pf/attachments/20040916/6e5cef24/attachment.bin