[pf4freebsd] Re: pfflowd port

[Andrew Thompson]

On Tue, Feb 24, 2004 at 01:35:55AM +0100, Max Laier wrote:
> On Tuesday 24 February 2004 01:15, Andrew Thompson wrote:
> > Hi all,
> >
> > I have created a port for pfflowd and thought i'd get feedback before
> > submitting a PR.
> >
> > It can be found @
> >
> > http://www.fud.org.nz/pfflowd-port.tar.gz
> 
> Okay, some feedback:
> 1) You copied from security/pf (which is okay), but you should update the 
> pkg-descr.

oops, my bad.

> 2) pkg-plist is empty, but should contain:
> sbin/pfflowd
> etc/rc.d/pfflowd.sh.sample

oops again :)

> 3) Not sure what the patch for pfflowd.c should do. What is wrong with the 
> check for invalid ports?

It generated a gcc warning, as addr->sin_port is a uint16_t which cant
be negative or >65536. -Werror made this fatal.

> 4) Maybe get the pidfile.{c,h} from us (include/support/) and add them 
> instead of just removing <util.h> and pidfile support.

Thanks, I wasnt sure where pidfile() came from.


Andy