maintainer-approval requested: [Bug 193934] Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)" : [Attachment 147679] Fix bogus *** Error 1 (ignored) and reinstate error check for ${FIND}/${SED}.

[bugzilla-noreply at freebsd.org]

Matthias Andree <mandree at FreeBSD.org> has asked perl at FreeBSD.org for
maintainer-approval:
Bug 193934: Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193934

Attachment 147679: Fix bogus *** Error 1 (ignored) and reinstate error check
for ${FIND}/${SED}.
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147679&action=edit


------- Additional Comments from Matthias Andree <mandree at FreeBSD.org>
ports/Mk/Uses/perl5.mk abuses shell list sequencing with "&&" operators, and
this causes bogus errors in make on ports that run fix-packlist without the
SITE_PERL_REL/PERL_ARCH/auto dir installed, for instance, marino's upcoming
net-mgmt/netdisco port.

The syntax goes along these lines:

- at a && b

But if "a" failing isn't an error, then instead we should write:

if a ; then b ; fi

This will also ensure that errors from b are NOT ignored (they are now).

Proposed patch attached.  Please check if this needs an -exp run.