svn commit: r349107 - in head/converters/p5-Text-Iconv: . files

[Guido Falsi]

On 03/25/14 15:40, Tijl Coosemans wrote:
> Thanks, I received a PR about this yesterday:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=187907
> 
> The OSVERSION check isn't correct though.  It should be empty(ICONV_LIB).
> But, I've attached a patch that uses a different approach.  You can
> make the port use /usr/include/iconv.h by replacing LOCALBASE in
> CONFIGURE_ARGS with ICONV_PREFIX.
> 
> That fixes the build phase, during configure however, something(?) is
> still adding -I/usr/local/include to the command line so you still need
> -DLIBICONV_PLUG when empty(ICONV_LIB).  The patch adds CFLAGS to INC in
> CONFIGURE_ARGS for this.  You can verify this by adding verbose=1 to
> CONFIGURE_ARGS and running "make configure".
> 
> Can perl@ review/approve this?

I did not think about stuffing CFLAGS in INC, good catch! :)

I did not see that PR, I would have filed my patch as followup if I had.

-- 
Guido Falsi <madpilot at FreeBSD.org>