FreeBSD Port: editors/libreoffice

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-10-29 14:25:03 -0400, Baptiste Daroussin wrote:
> On Tue, Oct 29, 2013 at 01:17:15PM -0400, Jung-uk Kim wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> On 2013-10-29 01:47:53 -0400, Robert Burmeister wrote:
>>> I was building libreoffice 4.0.6 just fine on FreeBSD 9.2 i386
>>> with clang-devel-3.4.r191854
>>> 
>>> libreoffice 4.0.6_1 now requires clang-3.3 ???
>>> 
>>> Shouldn't the requirement be clang-3.3+ ?
>> 
>> I got rid of home-grown heuristics to select C++11 compiler and
>> now we switched to more canonical "USES=compiler:c++11-lang".
>> This change fixes build:
>> 
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=183392
>> 
>> Unfortunately, it has few side-effects, e.g.,
>> 
>> - - Default C++11 compiler is lang/clang33.  Optionally, GCC may
>> be selected. - - Clang 3.2 is completely banned (hard-coded).
>> Other Clang versions, e.g., lang/clang-devel, are not supported.
>> AFAICT, there is no official way to override it.
> 3.2 is banned on purpose, we have so many bug fixes that has been
> made post 3.2 that we decided to ban everything lowey than 3.2,

Agreed 100%.  However, I think we need an override mechanism so that
the maintainer can ultimately decide, i.e., "I know some version is
buggy but this port is proven working flawlessly with any Clang version."

> Concerning the PR if the user defines in make.conf properly 3.4
> with CC, CXX etc it will work,

I think it will work.  However, it isn't flexible as USE_GCC, e.g.,
"USE_GCC=4.6+", as the OP expected.

> anyway I'll be working on using clang-devel is possible.

Thanks!

>> - - 9.2-RELEASE has Clang 3.3 for amd64/i386 but compiler.mk
>> ignores it because it is not the default C++ compiler.
> 
> Yes I'm planning to add support for that.

Awesome!

>> I don't want to re-add the previous heuristics because it is hard
>> to maintain.
> 
> That is exactly why I created compiler.mk, I'll improve it.
> 
> Thanks for reporting

Thank YOU for writing compiler.mk!

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQEcBAEBAgAGBQJScAKXAAoJEHyflib82/FG4TsH/j5oNkFm3RtEBXczhw1Z2rpq
OwWU6jzTfI8zQvnAJkEgtpmRxcIlqDuByLjCDkpeych2UL5GJGF9T4OTk8beQ2cH
k1F7v/nIVFjBHD8YFoKAvQtqbdLl9EAoWqoUQPWWxSXHjhxmMYA4kEQ1UTaeUuwc
upg7bznX8dAUzUsrjHdXW5GMy/W+ANtNvGGkMxzVyLHduLF/BVx5GxionxwYHnhZ
s2+uVgfujnQK/5s/Dvg+icuVcLoiP6x/nRJw83csDtZoAJOl17pYTe+dEGO/ipr4
/qNVoMwvFpTayKP2XpJUuiRm9OiW8+Rh2Rf4einuc+PXXAjDLxGjCs+BCeE8lPI=
=wtfe
-----END PGP SIGNATURE-----