[Bug 222247] libmsun tests does not compile during a buildworld

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Sep 13 06:53:46 UTC 2017


--- Comment #6 from Ryan Libby <rlibby at freebsd.org> ---
(In reply to Bertrand Petit from comment #5)

For the underlying bug, yes I think deconflicting the namespace is the
right approach, rather than having libmsun try to use the kernel macros.
I think there are still two different problems:

 - Use of reserved identifiers.  Neither libmsum nor the kernel headers
   should be defining identifiers that start with double underscores.
 - Kernel header namespace pollution.  The kernel macros, after being
   renamed to something not reserved, should be #undef'd at the end of
   the headers.

Attachment 186320 moves the i386 kernel header names out of the way, but
leaves the amd64 ones, and still uses inappropriate reserved names.

Thanks for your interest.  I'm also trying to remove places where we
silence warnings.  I suggest we get the bug at hand resolved and then
clone a new bug targeting head to do this cleanup, since we aren't going
to do it by direct commit to stable/11 anyway.  If you are familiar with
Phabricator (https://wiki.freebsd.org/Phabricator), feel free to submit
a patch there.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the freebsd-numerics mailing list