[Bug 243126] iflib: Assertion fl->ifl_cidx == cidx failed at /usr/src/sys/net/iflib.c:2531 with if_vmx(4)

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Mar 14 20:09:01 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243126

--- Comment #11 from commit-hook at freebsd.org ---
A commit references this bug:

Author: pkelsey
Date: Sat Mar 14 20:08:04 UTC 2020
New revision: 359000
URL: https://svnweb.freebsd.org/changeset/base/359000

Log:
  Fix if_vmx receive checksum offload bug and harden against the device
skipping receive descriptors

  This fixes a bug where the checksum offload status of received packets
  was being taken from the first descriptor instead of the last, which
  affected LRO packets.

  The driver has been hardened against the device skipping receive
  descriptors, although it is not believed that this can occur given the
  way this implementation configures the receive rings.

  Additionally, for packets received with the error indicator set, the
  driver now forces the length of all fragments in that packet to zero
  prior to passing it to iflib.  Such packets should wind up being
  discarded at some point in the stack anyway, but this removes any
  questions by killing them in the driver.

  Counters have been added (and exposed via sysctls) for skipped receive
  descriptors, zero-length packets received, and packets received with
  the error indicator set so that these conditions can be easily
  observed in the field.

  PR:           243126, 243392, 240628
  Reported by:  avg, alexandr.oleynikov at gmail.com, Harald Schmalzbauer
  Reviewed by:  gallatin
  MFC after:    1 week
  Differential Revision:        https://reviews.freebsd.org/D23949

Changes:
  head/sys/dev/vmware/vmxnet3/if_vmx.c
  head/sys/dev/vmware/vmxnet3/if_vmxvar.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.


More information about the freebsd-net mailing list