[Differential] D24937: Add sysctl net.iflib.tx_update_freq to set transmit descriptor update frequency

[aleksandr.fedorov_itglobal.com (Aleksandr Fedorov)]

aleksandr.fedorov_itglobal.com added inline comments.

INLINE COMMENTS

> iflib.c:2916
>  
>  #define TXD_NOTIFY_COUNT(txq) (((txq)->ift_size / (txq)->ift_update_freq)-1)
>  static inline qidx_t

I am worried that if the user sets the value to 1, then this will lead to division by zero and to kernel panic. I think additional checks are needed.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D24937/new/

REVISION DETAIL
  https://reviews.freebsd.org/D24937

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: neel_neelc.org, shurd, #iflib
Cc: aleksandr.fedorov_itglobal.com, koobs, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com