[Differential] D24989: netinet: Generate a random RSS key on boot.

[markm (Mark R V Murray)]

markm requested changes to this revision.
markm added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> rss_config.c:251
>  	 */
> +	arc4random_buf(rss_key, RSS_KEYSIZE);
>  }

This scares me less than the previously hard-coded key, but if we are going to the trouble to randomise, then we need to sequence it properly.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D24989/new/

REVISION DETAIL
  https://reviews.freebsd.org/D24989

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: neel_neelc.org, #csprng, markm
Cc: markm, cem, #csprng, kevans, debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com