IF_DRV_PREPEND unlocked?

John-Mark Gurney jmg at funkthat.com
Wed Jul 15 23:26:38 UTC 2020


I happen to be looking at the implementation of IFQ_DRV_PREPEND, and
unlike IFQ_DRV_DEQUEUE, it doesn't obtain the lock when manipulating
the ifq.  I took a brief look at a few drivers, and it looks like some
of them expect that _PREPEND lock the Q like _DEQUEUE does.

This is likely not an issue often, since it's an error path that likely
rarely happens, but we should fix it.

Should we just add the IFQ_LOCK/_UNLOCK to the macro?

Comments or thoughts?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."


More information about the freebsd-net mailing list