Strange logic in r336438

Eric van Gyzen eric at vangyzen.net
Thu Jan 16 23:31:40 UTC 2020


I was just reviewing r336438:

https://svnweb.freebsd.org/base?view=revision&revision=336438

In bxe_interrupt_detach(), the nested loops over sc->num_queues don't 
look right.  We drain the taskqueues for queue 0, but then free the 
taskqueues for queues 1-N without draining them.  Should the second loop 
come _after_ the first loop, instead of _in_ it?

Eric


More information about the freebsd-net mailing list