vmx: strange issue, related to to tso?
pkelsey at freebsd.org
Mon Dec 30 04:21:23 UTC 2019
On Sun, Dec 29, 2019 at 6:06 AM Andriy Gapon <avg at freebsd.org> wrote:
> On 28/12/2019 06:43, Patrick Kelsey wrote:
> > I am not able to test this at the moment, nor likely in the very near
> > but I did have a few minutes to do some code reading and now believe
> that the
> > following is part of the problem, if not the entire problem. Using
> r353803 as a
> > reference, I believe line 1323 in sys/dev/vmware/vmxnet3/if_vmx.c (in
> > vmxnet3_isc_txd_encap()) should be:
> > sop->hlen = hdrlen + ipi->ipi_tcp_hlen;
> > instead of the current:
> > sop->hlen = hdrlen;
> > This can be seen by going back to r333813 and examining the CSUM_TSO
> case of
> > vmxnet3_txq_offload_ctx(). The final increment of *start in that case
> is what
> > was literally lost in translation when converting the driver to iflib.
> thank you very much!
> The change (with s/ipi->/pi->/) fixes the problem for me.
Thank you for the test report. Also, thank you for pointing out the typo -
indeed, this line of code was not run through the
More information about the freebsd-net