[Bug 231151] ifconfig: unable to disable rxcsum, rxcsum6 and vlanhwcsum on em driver

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231151

--- Comment #13 from commit-hook at freebsd.org ---
A commit references this bug:

Author: shurd
Date: Thu Sep 20 19:35:35 UTC 2018
New revision: 338838
URL: https://svnweb.freebsd.org/changeset/base/338838

Log:
  Fix capabilities handling for iflib drivers

  Various capabilities were not being handled correctly in the
  SIOCSIFCAP handler. Specifically:

  IFCAP_RXCSUM and IFCAP_RXCSUM_IPV6 could be set even if not supported

  It was impossible to disable IFCAP_RXCSUM and/or IFCAP_RXCSUM_IPV6 via
  ifconfig since it does ioctl() per command-line flag rather than combine
  them into a single call.

  IFCAP_VLAN_HWCSUM could not be modified via the ioctl()

  Setting any combination of the three IFCAP_WOL flags would set only
  IFCAP_WOL_MCAST | IFCAP_WOL_MAGIC. For example, setting only
  IFCAP_WOL_UCAST would result in both IFCAP_WOL_MCAST and IFCAP_WOL_MAGIC
  being enabled, but IFCAP_WOL_UCAST would not be enabled.

  Because if_vlancap() was called before if_togglecapenable(), vlan flags
  were sometimes not applied correctly.

  Interfaces were being unnecessarily stopped and restarted for WoL

  PR:           231151
  Submitted by: Kaho Toshikazu <kaho at elam.kais.kyoto-u.ac.jp>
  Reported by:  Shirkdog <mshirk at daemon-security.com>
  Reviewed by:  galladin
  Approved by:  re (gjb)
  Sponsored by: Limelight Networks
  Differential Revision:        https://reviews.freebsd.org/D17158

Changes:
  head/sys/net/iflib.c

-- 
You are receiving this mail because:
You are the assignee for the bug.