[Bug 231659] [em][igb] 12-ALPHA8 r339259 crashes on receive under load

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231659

--- Comment #46 from commit-hook at freebsd.org ---
A commit references this bug:

Author: erj
Date: Sun Oct 14 05:09:44 UTC 2018
New revision: 339354
URL: https://svnweb.freebsd.org/changeset/base/339354

Log:
  em/igb/ix(4): Port two Tx/Rx fixes made to ixl in r339338

  - Fix assert/panic on receive when Jumbo Frames are enabled.

  From the commit I made to ixl:
  "It turns out that *_isc_rxd_available is supposed to return how many
  packets are available to be cleaned on the rx ring. This patch removes
  a section of code where if the budget argument is 1, the function would
return
  one if there was a descriptor available, not necessarily a packet.

  This is okay in regular mtu 1500 traffic since the max frame size is less
  than the configured receive buffer size (2048), but this doesn't work when
  received packets can span more than one  descriptor, as is the case when the
  mtu is 9000 and the receive buffer size is 4096."

  - Fix possible Tx hang because *_isc_txd_credits_update returns incorrect
result

  From the commit by Krzysztof Galazka to ixl: "Function isc_txd_update_credits
  called with clear set to false should return 1 if there are TX descriptors
  already handled by HW. It was always returning 0 causing troubles with UDP TX
  traffic."

  PR:             231659
  Reported by:    lev@
  Approved by:  re (gjb@)
  Sponsored by:   Intel Corporation

Changes:
  head/sys/dev/e1000/em_txrx.c
  head/sys/dev/e1000/igb_txrx.c
  head/sys/dev/ixgbe/ix_txrx.c

-- 
You are receiving this mail because:
You are the assignee for the bug.