[Bug 231416] dhcp / dhclient: bad udp checksums if running on a vlan on a Intel I211 / Broadcom interfaces

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Oct 5 20:17:17 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231416

--- Comment #12 from commit-hook at freebsd.org ---
A commit references this bug:

Author: shurd
Date: Fri Oct  5 20:16:20 UTC 2018
New revision: 339207
URL: https://svnweb.freebsd.org/changeset/base/339207

Log:
  Fix igb corrupting checksums with BPF and VLAN

  When using a vlan with igb and the vlanhwcsum option, any mbufs which
  already had the TCP, UDP, or SCTP checksum calculated and therefore don't
  have the CSUM_[IP|IP6]_[TCP|UDP|SCTP] bits set in the csum_flags field would
  have the L4 checksum corrupted by the hardware.

  This was caused by the driver setting E1000_TXD_POPTS_TXSM any time a
  checksum bit was set OR a vlan tag was present.

  The patched driver only sets E1000_TXD_POPTS_TXSM when an offload is
  requested.

  PR:           231416
  Reported by:  pi
  Approved by:  re (gjb)
  Sponsored by: Limelight Networks
  Differential Revision:        https://reviews.freebsd.org/D17404

Changes:
  head/sys/dev/e1000/igb_txrx.c

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-net mailing list