[Differential] D12457: Complete INADDR_HASH lock protection

eugen_grosbein.net (Eugene Grosbein) phabric-noreply at FreeBSD.org
Tue Sep 26 11:00:52 UTC 2017


eugen_grosbein.net marked 2 inline comments as done.
eugen_grosbein.net added a comment.


  In https://reviews.freebsd.org/D12457#258249, @rwatson wrote:
  
  > Many of these changes are not sufficient to address the underlying problems in this code, as the lock covers loop iteration but fails to protect the stability of the 'ifp' or 'ia' pointer outside of the loop.
  
  
  Yes, it's true but that's distinct and much larger problem. I am not going to solve all such problems at once with my first commit to src. I prefer to fix things one by one when it is possible with small changes.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D12457

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp, freebsd-net-list


More information about the freebsd-net mailing list