vmxnet3 driver bug?

[Bryan Venteicher]

On Tue, Oct 17, 2017 at 9:36 AM, Lewis Donzis <lew at perftech.com> wrote:

> The VMXNET3 driver appears to have a bug that prevents it from correctly
> reporting when the link goes down.
>
> There are two lines of code that should be deleted in
> /usr/src/sys/dev/vmware/vmxnet3/if_vmx.c:
>
> @@ -3619,8 +3619,6 @@ vmxnet3_media_status(struct ifnet *ifp, struct
> ifmediareq *ifmr)
>         VMXNET3_CORE_LOCK(sc);
>         if (vmxnet3_link_is_up(sc) != 0)
>                 ifmr->ifm_status |= IFM_ACTIVE;
> -       else
> -               ifmr->ifm_status |= IFM_NONE;
>         VMXNET3_CORE_UNLOCK(sc);
>  }
>
> IFM_NONE doesn’t belong in the status flags and, coincidentally, is
> defined with an identical value as IFM_ACTIVE, so it indicates that link is
> always active.
>
>
This should be fixed in r326309 that I'll merge to the stable branches in a
week.


> Thanks,
> lew
> _______________________________________________
> freebsd-net at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe at freebsd.org"