[Differential] D10485: Replace dhcp option 150 by 66

Tue May 2 05:27:37 UTC 2017

tsoome added a comment.

  In https://reviews.freebsd.org/D10485#218907, @kczekirda wrote:

  > Until I go forward with your comments about the code I want to highlight it's not possible to support option 150, because we have to ask DHCP server for this option. PXE client (I mean network card firmware) never asks about option 150. I can't see any chance to use this non standard option but revert r314948 and always do DHCP request for everything. The second option is doing DHCP request in #ifdef LOADER_TFTP_SUPPORT directive, what is something bad too, because we want to have one universal loader for both (NFS and TFTP) protocols. The third option is to force DHCP request in ifdef directive when somebody really wants to do this. And the last one option - to leave support for option 150, because it has never appear in the documentation. I can't see any really good solution, now your move to comment.

  Note that dhcp servers in real life can offer all the configured data. And well, we can process both 66 and 150 just because that data may be there anyhow.

  But also there is much simpler way to distinguish NFS versus TFTP boot - because that is the problem - how  to understand if we should go for NFS of for TFTP.  And the idea is simple - if there is no server set, we opt to use next server option for nfs/tftp server; now the root_path syntax as such is not set, therefore we can just state that if the root_path is  IP:/path then its NFS, if the root_path is /path, then it is TFTP.

  Meanwhile I would also like to move on with https://reviews.freebsd.org/D10232 :)

REVISION DETAIL
  https://reviews.freebsd.org/D10485

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp, jhb
Cc: rgrimes, garga, ler, asomers