[Differential] D8685: Fix a false positive in a buf_ring assert

hselasky (Hans Petter Selasky) phabric-noreply at FreeBSD.org
Wed Nov 30 22:04:19 UTC 2016


hselasky added inline comments.

INLINE COMMENTS

> buf_ring.h:71
> +	if (br->br_cons_head != br->br_prod_head) {
> +		for (i = br->br_cons_head + 1; i != br->br_prod_head;
> +		    i = ((i + 1) & br->br_cons_mask))

should "br->br_cons_head + 1" be masked by br->br_cons_mask ??

REVISION DETAIL
  https://reviews.freebsd.org/D8685

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: rstone
Cc: hselasky, freebsd-net-list, emaste


More information about the freebsd-net mailing list