[Differential] D6689: tcp/lro: Implement hash table for LRO entries.

[sepherosa_gmail.com (Sepherosa Ziehau)]

sepherosa_gmail.com added a comment.


  In https://reviews.freebsd.org/D6689#142118, @gallatin wrote:
  
  > Looks good in terms of not killing perf. for the sorted case, and I'm fine with it as-is.   However,   maybe an else would be better than a goto?
  
  
  Yeah, sure, I can move the bucket assignment into the {}, and use if-elseif-else to avoid goto.
  
  And as for performance, I am running the test using hash table currently.  The result of nginx+wrk test is quite promising (web object sizes range from 1KB~40KB; for 4reqs/conn, 4~10K concurrent connection, I am getting 12%~14% performance improvement :).  14reqs/conn nginx+wrk test is still running.

REVISION DETAIL
  https://reviews.freebsd.org/D6689

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, rrs, glebius, gnn, bz, rwatson, #transport, hselasky, gallatin
Cc: freebsd-net-list