[Differential] [Requested Changes To] D5872: tcp: Don't prematurely drop receiving-only connections

[jtl (Jonathan T. Looney)]

jtl requested changes to this revision.
jtl added a reviewer: jtl.
jtl added a comment.
This revision now requires changes to proceed.


  Doesn't tp->t_rxtshift get updated on a successful send? If not, I think that is what we should be fixing.
  
  Personally, I think a connection should drop if we aren't able to send any ACKs for 350 seconds.

INLINE COMMENTS
  sys/netinet/tcp_output.c:1561 You already own a lock on tp. No need to do atomic operations.

REVISION DETAIL
  https://reviews.freebsd.org/D5872

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, hiren, lstewart, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, transport, jtl
Cc: jtl