[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

imp (Warner Losh) phabric-noreply at FreeBSD.org
Thu Jan 29 16:15:08 UTC 2015


imp added a comment.

I agree that the kernel test framework should be done differently as well.

I didn't realize the number of mechanical changes my request to use the macros produced :(

INLINE COMMENTS
  sys/sys/callout_test.h:1 I'm not sure that the callout_test.h belong in sys. Seems like needless pollution.
  sys/sys/kern_testfrwk.h:1 Does this need to live in sys as well?

REVISION DETAIL
  https://reviews.freebsd.org/D1711

To: rrs, gnn, rwatson, adrian, sbruno, lstewart, imp, hselasky
Cc: jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net


More information about the freebsd-net mailing list