Double cleanup in igb_attach

hiren panchasara hiren at strugglingcoder.info
Tue Jan 27 19:50:27 UTC 2015


On Tue, Jan 27, 2015 at 07:36:17PM +0000, Sreekanth Rupavatharam wrote:
> >
> >Seems reasonable to me at the first glance.
> >
> >We need to call IGB_CORE_LOCK_DESTROY(adapter) before returning though.
> >
> Not necessary. igb_detach does that.

Bah, I read that call inside detach as UNLOCK. Yeah, you are right. 

cheers,
Hiren
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-net/attachments/20150127/f635bccf/attachment.sig>


More information about the freebsd-net mailing list