[Differential] [Accepted] D1764: Factor out ip6_deletefraghdr()
glebius (Gleb Smirnoff)
phabric-noreply at FreeBSD.org
Thu Feb 12 20:10:00 UTC 2015
glebius added a subscriber: glebius.
glebius accepted this revision.
glebius added a reviewer: glebius.
glebius added a comment.
This revision is now accepted and ready to land.
Thanks. Patch looks good to me, but see comments. We probably need a nod from a IPv6 expert. I'll send link to ae at .
INLINE COMMENTS
sys/netinet6/ip6_output.c:1215 Comment should end in dot.
sys/netinet6/ip6_output.c:1217 Comment should end in dot.
sys/netinet6/ip6_output.c:1218 Can you please use bcopy() here. And you don't need first caddr_t cast. The second cast should be changed to char *.
sys/netinet6/ip6_output.c:1223 Please capitalize comment and end it in dot.
sys/netinet6/ip6_output.c:1224 Let's add third argument 'wait' to ip6_deletefraghdr(). The argument will be passed directly to m_split().
sys/netinet6/ip6_var.h:391 Need single whitespace between 'mbuf' and '*'.
REVISION DETAIL
https://reviews.freebsd.org/D1764
To: kristof, glebius
Cc: glebius, freebsd-net
More information about the freebsd-net
mailing list