[Differential] [Accepted] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

[imp (Warner Losh)]

imp accepted this revision.
imp added a comment.

I think we're ready to land. It fixes all the issues discussed, and enhanced testing shows no additional errors.

INLINE COMMENTS
  kern/kern_timeout.c:1159 "When the callout wheel runs, it will ignore this callout" maybe is a better phrase to use here rather than have an ambiguous "callout" that refers to two different things in the same sentence.
  
  kern/kern_timeout.c:1234 tiny nit: I think this is indented wrong, but Phabric is so lame I can't tell for sure. Please check and fix if it isn't indented 4 spaces. 
  sys/callout.h:67 I'd be tempted to create a callout_processed() macro too and use it in the last chunk of kern_timeout.c, but that can be done as a separate commit.

REVISION DETAIL
  https://reviews.freebsd.org/D1711

To: rrs, gnn, rwatson, sbruno, lstewart, jhb, kostikbel, hselasky, adrian, imp
Cc: jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net