[igb] add DROP_EN to each RX queue config if TX flow control is disabled

Adrian Chadd adrian at freebsd.org
Sun Sep 14 06:10:17 UTC 2014


On 13 September 2014 13:09, Eric Joyner <ricera10 at gmail.com> wrote:
> This looks good to me. The only comment I have is that according to the I350
> datasheet, DROP_EN is already set on all the queues but 0 by default, but I
> haven't checked for the other adapters covered by igb.

Right, but the igb_initialize_receive_units() function actually
overrides the queue SRRCTL; it doesn't do a read-modify-write of what
the initial defaults are.


-a


More information about the freebsd-net mailing list