nd6_timer vs Giant vs locking in general

Alexander V. Chernikov melifaro at FreeBSD.org
Fri Oct 24 09:33:30 UTC 2014


On 24.10.2014 09:26, Mateusz Guzik wrote:
> Hello there,
>
> dtrace revealed that the kernel schedules nd6_timer a lot. Not only
> that, his callout is not mpsafe so the kernel locks Giant which I
> believe is an oversight.
>
> Also the code looks really suspicious as it walks V_in6_ifaddrhead
> without any locking (not to mention there is an interestng comment:
> XXXRW: in6_ifaddrhead locking :>)
Yes, I'm going to fix some issues there after writing proper API.
ND changes are in https://reviews.freebsd.org/D903 .
>
> Dropping it here in case there is someone interested in fixing this up.
>



More information about the freebsd-net mailing list