kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion

[Mark Linimon]

The following reply was made to PR kern/179083; it has been noted by GNATS.

From: Mark Linimon <linimon at lonesome.com>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap
 macro expansion
Date: Thu, 30 May 2013 02:58:04 -0500

 ----- Forwarded message from Luigi Rizzo <rizzo at iet.unipi.it> -----
 
 Date: Thu, 30 May 2013 09:57:15 +0200
 From: Luigi Rizzo <rizzo at iet.unipi.it>
 To: freebsd-bugs at freebsd.org, freebsd-net at freebsd.org
 Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion
 User-Agent: Mutt/1.5.20 (2009-06-14)
 
 Thanks for the report.
 
 The macro is correct as implemented.
 The problem, in case, is in the description in netmap_user.h which
 is confusing and should be improved as follows:
 
 -*      char *buf = NETMAP_BUF(ring, index) returns a pointer to
 -*              the i-th buffer
 +*      char *buf = NETMAP_BUF(ring, x) returns a pointer to
 +*              the buffer numbered 'x'
 
 This will be committed soon, so please close the PR
 
 cheers
 luigi
 
 ----- End forwarded message -----