kern/110284: [if_ethersubr] Invalid Assumption in SIOCSIFADDR in ether_ioctl()

[Devon H. O'Dell]

2012/5/16 Devon H. O'Dell <devon.odell at gmail.com>:
> Hi Gavin, freebsd-net,
>
> --- if_ethersubr.c      2011-09-22 20:51:37.000000000 -0400
> +++ /home/dho/if_ethersubr.c    2012-05-16 22:27:17.000000000 -0400
> @@ -1146,7 +1146,9 @@
>                switch (ifa->ifa_addr->sa_family) {
>  #ifdef INET
>                case AF_INET:
> -                       ifp->if_init(ifp->if_softc);    /* before arpwhohas */
> +                       if (ifp->if_flags & IFF_RUNNING == 0) {

That's probably ((ifp->if_flags & IFF_RUNNING) == 0). Also, I'm not on
freebsd-net or cc'ed on the PR afaik, so please cc me explicitly on
followups if more information is needed.

--dho

> +                               ifp->if_init(ifp->if_softc);    /*
> before arpwhohas */
> +                       }
>                        arp_ifinit(ifp, ifa);
>                        break;
>  #endif