ifconfig meshforward command bug

Monthadar Al Jaberi monthadar at gmail.com
Fri Mar 23 09:12:47 UTC 2012


On Thu, Mar 22, 2012 at 7:56 PM, Adrian Chadd <adrian at freebsd.org> wrote:
> On 22 March 2012 11:56, Adrian Chadd <adrian at freebsd.org> wrote:
>> On 22 March 2012 11:28, Bernhard Schmidt <bschmidt at freebsd.org> wrote:
>>
>>> Seems about right, those declared with DEF_CMD() should use d.
>>
>> Shall I commit this?
>
> .. a lot of these mesh functions use DECL_CMD_FUNC(), should they all
> be using d?

No I dont think all of them should use d. If you send a value like for
meshttl for example you should not use d, d is only for enable/disable
flags, for example this is CORRECT:

static
DECL_CMD_FUNC(set80211meshttl, val, d)
{
	set80211(s, IEEE80211_IOC_MESH_TTL, atoi(val), 0, NULL);
}

br

>
>
> adrian



-- 
Monthadar Al Jaberi


More information about the freebsd-net mailing list