tcp failing to recover from a packet loss under 8.2-RELEASE?

[Andre Oppermann]

On 29.08.2011 02:08, Lawrence Stewart wrote:
> On 08/14/11 23:53, Steven Hartland wrote:
>> ----- Original Message ----- From: "Lawrence Stewart"
>> <lstewart at freebsd.org>
>>>
>>> Here's my tweaked version of Andre's patch:
>>> http://people.freebsd.org/~lstewart/patches/misctcp/tcp_reass.c-logdebug%2bmissingsegment-20110811-lstewart.diff
>>>
>>>
>>
>> Still testing this and just noticed that the patch fails to
>> compile when INVARIANTS is enabled. The KASSERT calls need
>> ()'s around the split strings.
>
> oops, sorry. Compile tested on 8-STABLE without INVARIANTS enabled :/
>
> Any further feedback with respect to the patch? Plan to submit it to re@ later this week for
> inclusion in 9.0.

I'm not sure these excessive KASSERT's are really necessary. Probably one
covering those cases at the start of the function is sufficient.

I was about to send the original patch to re@ for approval as well now
that I'm back from vacation and fully available again.  Don't mind if
you do it if you've got the time.

-- 
Andre