kern/135067: [patch] [fib] Incorrect KASSERTs in sys/net/route.c

[Mateusz Guzik]

The following reply was made to PR kern/135067; it has been noted by GNATS.

From: Mateusz Guzik <mjguzik at gmail.com>
To: Julian Elischer <julian at elischer.org>
Cc: bug-followup at freebsd.org
Subject: Re: kern/135067: [patch] [fib] Incorrect KASSERTs in sys/net/route.c
Date: Sat, 30 May 2009 10:42:25 +0200

 On Sat, May 30, 2009 at 3:58 AM, Julian Elischer <julian at elischer.org> wrot=
 e:
 > if you have 16 fibs then valid values are 0,1,2,.....14,15
 >
 > if fibnum =3D=3D rt_numfibs then that is an error.
 >
 > thus in setfib... if uap->numfbs is 16 OR GREATER =A0it is and EINVAL
 >
 > and the kasserts in route.c need to check that fibnum is =A0LESS THAN
 > rt_numfibs.
 >
 
 That's correct.
 
 >
 > what makes you think there is an error?
 >
 
 I somehow misread that KASSERT as triggered only when fibnum >
 rt_numfibs. I guess it was too late at night. :) Sorry for the noise.
 
 --
 Mateusz Guzik <mjguzik at gmail.com>