Wrong outgoing interface with multiple routing tables

Julian Elischer julian at elischer.org
Tue Jul 28 16:20:00 UTC 2009


Oleg Sharoyko wrote:
> Julian Elischer wrote:
> 
>> I'll get that checked in!
> 
> Please, also take a look at
> 
> _syncache_add() in tcp_syncache.c
> 
> There is some code which looks strange, at least at first sight. Won't 
> bcopy() overwrite assigned value of sc->sc_inc.inc_fibnum ?
> 
>         /* XXX-BZ this fib assignment is just useless. */
>         sc->sc_inc.inc_fibnum = inp->inp_inc.inc_fibnum;
>         bcopy(inc, &sc->sc_inc, sizeof(struct in_conninfo));

the bcopy just writes teh same vlue in again

I've removed this in the patch.

> 
> -- 
> Oleg



More information about the freebsd-net mailing list