[patch] src port randomization for inet6

Max Laier max at love2party.net
Fri Oct 17 02:59:36 UTC 2008


On Thursday 16 October 2008 15:05:16 Bjoern A. Zeeb wrote:
> so since the very early day of src port randomization ipv6 was missing
> that part while inet had it. Find a patch below.
> Please test, review and  report back...
>
> http://people.freebsd.org/~bz/20081004-07-ipv6-randomport.diff

looks good from a casual review.  Which is to say that it is in line with the 
in_pcb.c version.  However, I find the comment:

 /*
  * Simple check to ensure all ports are not used up causing
  * a deadlock here.
  */

a bit dangling and not really in line with the actual code.  The same is true 
for the v4 version.

-- 
/"\  Best regards,                      | mlaier at freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier at EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News


More information about the freebsd-net mailing list