kern/123741: [netgraph] [panic] kernel panic due to netgraph mpd

[Alexander Motin]

The following reply was made to PR kern/123741; it has been noted by GNATS.

From: Alexander Motin <mav at FreeBSD.org>
To: bug-followup at FreeBSD.org,  mimielliot at gmail.com
Cc:  
Subject: Re: kern/123741: [netgraph] [panic] kernel panic due to netgraph
 mpd
Date: Sat, 17 May 2008 11:15:52 +0300

 This is a multi-part message in MIME format.
 --------------070906020506060104050902
 Content-Type: text/plain; charset=KOI8-R
 Content-Transfer-Encoding: 7bit
 
 It looks like crash due to unchecked netgraph data items exhaustion.
 Attached patch should fix this crash, but problem may remain in some
 other symptoms. It would be good to investigate the reason of this
 exhaustion. It could be or just high netgraph load or some resource leak.
 
 -- 
 Alexander Motin
 
 --------------070906020506060104050902
 Content-Type: text/plain;
  name="ng_socket.c.enomem.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="ng_socket.c.enomem.patch"
 
 --- ng_socket.c.prev	2008-03-11 23:58:48.000000000 +0200
 +++ ng_socket.c	2008-05-17 10:36:46.000000000 +0300
 @@ -732,7 +732,8 @@ ng_connect_data(struct sockaddr *nam, st
  
  	sap = (struct sockaddr_ng *) nam;
  	/* The item will hold the node reference. */
 -	item = ng_package_data(NULL, NG_WAITOK);
 +	if ((item = ng_package_data(NULL, NG_WAITOK)) == NULL)
 +		return (ENOMEM);
  
  	if ((error = ng_address_path(NULL, item,  sap->sg_data, 0)))
  		return (error); /* item is freed on failure */
 
 --------------070906020506060104050902--