if_bridge turns off checksum offload of members?

[Stefan Lambrev]

Hi,

Sorry to reply to myself.

Stefan Lambrev wrote:
> Hi,
>
> May be a stupid questions, but:
>
> 1) There are zero matches of IFCAP_TOE in kernel sources .. there is 
> not support for TOE in 7.0, but may be this is work in progress for 
> 8-current?
> 2) In #define BRIDGE_IFCAPS_MASK (IFCAP_TOE|IFCAP_TSO|IFCAP_TXCSUM) - 
> TOE should be repleaced with RXCSUM or just removed?
Your patch plus this small change (replacing TOE with RXCSUM) seems to 
work fine for me - kernel compiles without a problem and checksum 
offload is enabled after reboot.
> 3) Why RX is never checked? In my case this doesn't matter because em 
> turn off both TX and RX if only one is disabled, but probably there is 
> a hardware,
> that can separate them e.g. RX disabled while TX enabled?
> 4) I'm not sure why bridge should not work with two interfaces one of 
> which support TX and the other does not? At least if I turn on 
> checksum offload
> only on one of the interfaces the bridge is still working ...
>
> Andrew Thompson wrote:
>
> - cut -
>>
>>
>> This patch should do that, are you able to test it Stefan?
>>
>>
>> cheers,
>> Andrew
>>   
> P.S. I saw very good results with netisr2 on a kernel from p4 before 
> few months .. are there any patches flying around so I can test them 
> with 7-STABLE? :)
>

-- 

Best Wishes,
Stefan Lambrev
ICQ# 24134177