ipv6 bugfix, need review.

[Alfred Perlstein]

* Doug Barton <dougb at FreeBSD.org> [081223 11:46] wrote:
> On Mon, 22 Dec 2008, Alfred Perlstein wrote:
> 
> >Hey guys, we found a bug at Juniper and it resolves an issue
> >for us.  I've been asked to forward this to FreeBSD, I honestly
> >am not that clear on the issue so I'm hoping someone can step
> >up to review this.
> >
> >Synopsis is:
> >
> > The traffic class byte is set to 0x00000000 in the header of some
> > BGP packets sent between interfaces that have IPv6 addresses,
> > instead of the correct setting 0xc0 (INTERNETCONTROL).
> >
> >Fix is small and attached.  One thing I am wondering, do we
> >need to check "if (inp)" ?  I don't think so.
> 
> How about adding an assert to the patch to prove this theory? :)
> 
> I'll test it on my home box (which has IPv6) as soon as I'm done with the 
> stuff I'm working on atm.
> 
> 
> hth,
> 
> Doug

Thanks Doug, will do.

Please let me know results.  do you know how to test if this is
actually being excersized?  I guess you could add a sysctl that
gets incremented each time this codepath is hit to test?


-- 
- Alfred Perlstein