panic: tcp_addoptions: TCP options too long w/ with TCP_SIGNATURE support

Andre Oppermann andre at freebsd.org
Tue Apr 1 13:39:35 PDT 2008


Rui Paulo wrote:
> On Tue, Apr 01, 2008 at 10:00:49PM +0200, Andre Oppermann wrote:
>> The order of the TCP options was changed recently to fix another problem.
>> This has caused sub-optimal padding and this overflow as not all options
>> fit.  The tcp_addoptions() loop is not bound internally.
>>
>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_output.c?rev=1.146
> 
> Hmm. Are you sure you wanted to show this revision ?
> There's not change for optlen because TCPOLEN_NOP == 1, I think.

Oops, wrong URL in paste buffer.  Try this:

  http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_var.h.diff?r1=1.160;r2=1.161

-- 
Andre


More information about the freebsd-net mailing list