kern/112710: [re] if_re driver detects incorrect b243a405a405 MAC address on SMC9452TX-1 pci gigabit cards

[David DeSimone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

W Forms <wforms at safe-mail.net> wrote:
>
> I don't really understand this, since from what I can see all that
> Pyun YongHyeon's changes do is replacing a constant value of 6 and 8
> with macros containing the value of 6 and 8.

Here's the patch as I recall it:


    -       sc->rl_eewidth = 6;
    +       sc->rl_eewidth = RL_9356_ADDR_LEN;
	    re_read_eeprom(sc, (caddr_t)&re_did, 0, 1);
	    if (re_did != 0x8129)
    -               sc->rl_eewidth = 8;
    +               sc->rl_eewidth = RL_9346_ADDR_LEN;

     /* 9346 EEPROM commands */
    +#define RL_9346_ADDR_LEN       6       /* 93C46 1K: 128x16 */
    +#define RL_9356_ADDR_LEN       8       /* 93C56 2K: 256x16 */

It looks to me like 6 was replaced with 8, and vice versa.  In other
words, a real bug fix.  :)

- -- 
David DeSimone == Network Admin == fox at verio.net
  "It took me fifteen years to discover that I had no
   talent for writing, but I couldn't give it up because
   by that time I was too famous.  -- Robert Benchley
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD4DBQFGimrKFSrKRjX5eCoRAlOeAJIDi2Y2+4ec8FpHpGEaxCa4lamsAKCRKr7g
0U6QjEHvLJWQ7HgfqHn9LQ==
=SZ5B
-----END PGP SIGNATURE-----