Proposal: remove encap from MROUTING

Bill Fenner fenner at research.att.com
Wed Feb 7 15:25:25 UTC 2007


>I plan to commit this patch some time this week.
>---mroute-notunnels.diff, text/x-patch follows---

Please do.  Only one comment:

>@@ -859,8 +816,6 @@ X_ip_mrouter_done(void)
>     /*
>      * Reset de-encapsulation cache
>      */
>-    last_encap_src = INADDR_ANY;
>-    last_encap_vif = NULL;
> #ifdef PIM
>     reg_vif_num = VIFI_INVALID;
> #endif

I think that comment goes with the removed lines so should be
removed with them.

While you're thinking about removing stuff, think about removing the
tbf code next.  There are way more flexible ways of rate limiting
traffic in the base system, so the tbf hack can and should just die.
Just return an error when trying to create a vif with a rate limit.

  Bill


More information about the freebsd-net mailing list