rfc2385 (tcp md5 checksums) in -current broken?

[othermark]

Noritoshi Demizu wrote:
 
> --- print-tcp.c-ORG   Thu Apr 21 15:36:05 2005
> +++ print-tcp.c       Wed Sep 21 18:43:51 2005
> @@ -799,7 +799,7 @@
>  MD5_Update(&ctx, tcpmd5secret, strlen(tcpmd5secret));
>  MD5_Final(sig, &ctx);
>  
> -     if (memcmp(rcvsig, sig, 16))
> +     if (memcmp(rcvsig, sig, TCP_SIGLEN) == 0)
>  return (SIGNATURE_VALID);
>  else
>  return (SIGNATURE_INVALID);

The original code there certainly looks wrong!  After patching, FreeBSD's
checksum returns valid.  I'll have to see what's up with the originating
checksum.  Many Thanks!

-- 
othermark
atkin901 at nospam dot yahoo dot com
(!wired)?(coffee++):(wired);